Ability to dismiss notifications #176
Labels
enhancement
Enhancement to an existing app/feature
Comments
|
Hi and welcome among us :) What do you mean by "dismiss the notification" ? Removing it from the list of notifications displayed in the notification app? |
|
Thank you. Yes, that is what I was thinking |
|
I could try to implement this. I was thinking about swipe right movement that could trigger a small remove icon which pops up from the right side of the screen and then second swipe right could remove the notification. A couple of swipes to the right could empty NotificationManager. Swipe left would close remove icon and the user will not be able to delete notification till he swipes right again. What do you think? |
|
FYI I started to work on that but I noticed that that first I need to learn a bit of LVGL :D Is there a simpler way to preview/install changes than using the Gagetbridge app that installs my custom stuff? Currently, I'm putting built soft on so online hosting, then download it on phone, and from that, I install it on PineTime. |
Yes, use a SWD programming dongle and use that to upload the firmware. |
Closed
|
Any progress on this? |
|
Is there currently no way to dismiss a notification? I've searched through a number of these issues which seem to indicate conflicting info about whether this is implemented or not. I've tried swiping left/right/up/down, long pressing, etc and can't remove a notification. |
NeroBurner
added a commit
that referenced
this issue
Jun 5, 2022
Rework notification ring buffer to have a begin-idx and a size_ internally. And add a new interface to access the notifications by index. The `0` index is always the latest notification. The second new function is a `Dismiss` function to remove the notification with a specified idx from the buffer. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 5, 2022
Rework notification ring buffer to have a begin-idx and a size_ internally. And add a new interface to access the notifications by index. The `0` index is always the latest notification. The second new function is a `Dismiss` function to remove the notification with a specified idx from the buffer. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 5, 2022
Rework notification ring buffer to have a begin-idx and a size_ internally. And add a new interface to access the notifications by index. The `0` index is always the latest notification. The second new function is a `Dismiss` function to remove the notification with a specified idx from the buffer. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 6, 2022
Rework notification ring buffer to have a begin-idx and a size_ internally. And add a new interface to access the notifications by index. The `0` index is always the latest notification. The second new function is a `Dismiss` function to remove the notification with a specified idx from the buffer. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 6, 2022
Rework notification ring buffer to have a begin-idx and a size_ internally. And add a new interface to access the notifications by index. The `0` index is always the latest notification. The second new function is a `Dismiss` function to remove the notification with a specified idx from the buffer. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 16, 2022
Rework notification ring buffer to have a begin-idx and a size_ internally. And add a new interface to access the notifications by index. The `0` index is always the latest notification. The second new function is a `Dismiss` function to remove the notification with a specified idx from the buffer. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 25, 2022
Rework notification ring buffer to have a begin-idx and a size_ internally. And add a new interface to access the notifications by index. The `0` index is always the latest notification. The second new function is a `Dismiss` function to remove the notification with a specified idx from the buffer. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: NeroBurner <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 26, 2022
Add a new interface `NotificationManager::Dismiss(id)` to delete a notification with the specified `id`. The animate the notification dismiss the `RightAnim` transition to a black screen is used. After the dismiss the new message is swiped in from below or above. If we dismiss the oldest message (when we are at 5/5, or 3/3), then the new message after a dismiss should appear to come from below. Otherwise (when we are at 2/3) the new message after a dismiss should appear to come from above. Rework the index code to show the index of the currently viewed notification. Instead of calculating the index relative to the oldest `id` introduce a new interface `NotificationManager::IndexOf(id)`. This is done because the `id` of the notifications in the buffer aren't continuous anymore (as some messages could have been dismissed). Rework notification ring buffer to have a beginIdx and a size internally to make the dismissal of notifications easier. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: Reinhold Gschweicher <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 26, 2022
Add a new interface `NotificationManager::Dismiss(id)` to delete a notification with the specified `id`. The animate the notification dismiss the `RightAnim` transition to a black screen is used. After the dismiss the new message is swiped in from below or above. If we dismiss the oldest message (when we are at 5/5, or 3/3), then the new message after a dismiss should appear to come from below. Otherwise (when we are at 2/3) the new message after a dismiss should appear to come from above. Rework the index code to show the index of the currently viewed notification. Instead of calculating the index relative to the oldest `id` introduce a new interface `NotificationManager::IndexOf(id)`. This is done because the `id` of the notifications in the buffer aren't continuous anymore (as some messages could have been dismissed). Rework notification ring buffer to have a beginIdx and a size internally to make the dismissal of notifications easier. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: Reinhold Gschweicher <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 26, 2022
Add a new interface `NotificationManager::Dismiss(id)` to delete a notification with the specified `id`. The animate the notification dismiss the `RightAnim` transition to a black screen is used. After the dismiss the new message is swiped in from below or above. If we dismiss the oldest message (when we are at 5/5, or 3/3), then the new message after a dismiss should appear to come from below. Otherwise (when we are at 2/3) the new message after a dismiss should appear to come from above. Rework the index code to show the index of the currently viewed notification. Instead of calculating the index relative to the oldest `id` introduce a new interface `NotificationManager::IndexOf(id)`. This is done because the `id` of the notifications in the buffer aren't continuous anymore (as some messages could have been dismissed). Rework notification ring buffer to have a beginIdx and a size internally to make the dismissal of notifications easier. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: Reinhold Gschweicher <pyro4hell@gmail.com>
NeroBurner
added a commit
that referenced
this issue
Jun 26, 2022
Add a new interface `NotificationManager::Dismiss(id)` to delete a notification with the specified `id`. The animate the notification dismiss the `RightAnim` transition to a black screen is used. After the dismiss the new message is swiped in from below or above. If we dismiss the oldest message (when we are at 5/5, or 3/3), then the new message after a dismiss should appear to come from below. Otherwise (when we are at 2/3) the new message after a dismiss should appear to come from above. Rework the index code to show the index of the currently viewed notification. Instead of calculating the index relative to the oldest `id` introduce a new interface `NotificationManager::IndexOf(id)`. This is done because the `id` of the notifications in the buffer aren't continuous anymore (as some messages could have been dismissed). Rework notification ring buffer to have a beginIdx and a size internally to make the dismissal of notifications easier. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: Reinhold Gschweicher <pyro4hell@gmail.com>
JF002
pushed a commit
that referenced
this issue
Jun 28, 2022
Add a new interface `NotificationManager::Dismiss(id)` to delete a notification with the specified `id`. The animate the notification dismiss the `RightAnim` transition to a black screen is used. After the dismiss the new message is swiped in from below or above. If we dismiss the oldest message (when we are at 5/5, or 3/3), then the new message after a dismiss should appear to come from below. Otherwise (when we are at 2/3) the new message after a dismiss should appear to come from above. Rework the index code to show the index of the currently viewed notification. Instead of calculating the index relative to the oldest `id` introduce a new interface `NotificationManager::IndexOf(id)`. This is done because the `id` of the notifications in the buffer aren't continuous anymore (as some messages could have been dismissed). Rework notification ring buffer to have a beginIdx and a size internally to make the dismissal of notifications easier. Fixes: #176 Co-authored-by: Simon Willshire <me@simonwillshire.com> Co-authored-by: Reinhold Gschweicher <pyro4hell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have just received my pinetime, so it is very possible that I am missing
something, however, I can't find a way to dismiss notifications.
I am running version 0.10.0
Thanks in advance
The text was updated successfully, but these errors were encountered: