[POC] Feature Favorite Apps on swipe left #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs like additional whitespaces
This reverts commit 378fa6b.
Improvement to the mapping of battery percentage to the battery icon to be displayed.
Remove the unused include `app_timer.h` in `MotorController.h`
…_include Remove unused include in MotoController.h
Run CI on master and develop branch
`xTaskGetTickCount()` returns a `TickType_t`, which is defined as an `uint32_t`. This is compared to the `bpm` variable, which is a `int16_t` in the range of 40 to 220 as defined in the constructor. ```cpp lv_arc_set_range(bpmArc, 40, 220); ``` Just assume that `bpm` is greater than 0, as this would result in a divison by zero or negative values, which would unintentionally underflow to a very large number.
This reverts commit 1d43adc.
Basic alarm app
…ime into geekbozu-PersistantStorage # Conflicts: # src/systemtask/SystemTask.cpp
…ng_metronome Fix unsigned/signed comparison warning in Metronome.cpp
…stored from the noinit area, the date was displayed as "--" instead of the actual date. This issue was caused by DateTime::SetCurrentTime() that would not update the internal state of the class : dayOfWeek, Month, Year were not properly updated according to the current time.
Toggle notifications only, keep vibrations.
|
Hi all, I'm not quite sure what went wrong that this PR has so many commits - however I got to implement the "long tap to select favorite" option. However I need help here - for some reason the watch crashes when I don't use a static Application when saving a favorite (tile.cpp -> apps[buttonId] ) . Can someone help me out here? |
|
Any chance you can clean up the PR so we can have a look more easily? I tested this yesterday and it seems to work well but it's a bit of a pain to merge currently |
|
I hope you'll bring this back, I was testing it because people were asking for it, and it works nicely! |
|
I did some cleaning up and we can continue the discussion on PR #708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a POC instead of pretty code, but this PR adds a favorite option when swiping left, including the configurable options.
Issues with this currently:
favorites_demo.mp4
]