code cleanup

Infisical · Dec 9, 2024 · 46fc06d · 46fc06d
1 parent dfa3e3c
commit 46fc06d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/backend/src/ee/services/secret-approval-policy/secret-approval-policy-dal.ts b/backend/src/ee/services/secret-approval-policy/secret-approval-policy-dal.ts
@@ -178,8 +178,7 @@ export const secretApprovalPolicyDALFactory = (db: TDbClient) => {
   };
 
   const softDeleteById = async (policyId: string, tx?: Knex) => {
-    const date = new Date();
-    const softDeletedPolicy = await secretApprovalPolicyOrm.updateById(policyId, { deletedAt: date }, tx);
+    const softDeletedPolicy = await secretApprovalPolicyOrm.updateById(policyId, { deletedAt: new Date() }, tx);
     return softDeletedPolicy;
   };
 

diff --git a/backend/src/ee/services/secret-approval-policy/secret-approval-policy-service.ts b/backend/src/ee/services/secret-approval-policy/secret-approval-policy-service.ts
@@ -305,15 +305,16 @@ export const secretApprovalPolicyServiceFactory = ({
       });
     }
 
-    await secretApprovalPolicyDAL.transaction(async (tx) => {
+    const deletedPolicy = await secretApprovalPolicyDAL.transaction(async (tx) => {
       await secretApprovalRequestDAL.update(
         { policyId: secretPolicyId, status: RequestState.Open },
         { status: RequestState.Closed },
         tx
       );
-      await secretApprovalPolicyDAL.softDeleteById(secretPolicyId, tx);
+      const updatedPolicy = await secretApprovalPolicyDAL.softDeleteById(secretPolicyId, tx);
+      return updatedPolicy;
     });
-    return sapPolicy;
+    return deletedPolicy;
   };
 
   const getSecretApprovalPolicyByProjectId = async ({