-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Integrations #1398
Github Integrations #1398
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic Password | 9282dd0 | docker-compose.dev.yml | View secret | |
- | Generic Password | 9282dd0 | docker-compose.dev.yml | View secret | |
- | Generic Password | 9282dd0 | .env.example | View secret | |
- | Generic Password | 9282dd0 | docker-compose.pg.yml | View secret | |
- | Generic Password | 9282dd0 | docker-compose.pg.yml | View secret | |
- | Generic High Entropy Secret | 9282dd0 | .env.example | View secret | |
- | Generic Private Key | f77942c | backend/e2e-test/routes/v3/secrets.spec.ts | View secret | |
- | Generic Private Key | f77942c | backend/e2e-test/routes/v3/secrets.spec.ts | View secret | |
- | Generic High Entropy Secret | f77942c | .env.test.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
integrations section for
Note that the schema being used was mongo. I updated the schema to match the current pg table. And also |
@akhilmhdh should I move to zod form resolver instead of yup? |
This is ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the PR yet, but it looks good. Great to have the feature and the docs at the same time 💪🏽
Sorry about the delay @Salman2301. I will put this on the teams radar for next sprint |
Hey @Salman2301! I made some changes to the code. Can you help fix a few edge-cases:
Screenshot illustrating 1: Screenshot illustrating 2: |
Both issue fixed with a simple disabled passed to select component. |
Description 📣
This PR is focus on updating the current Github Integrations and also add Organization and Environment sync.
react-hook-form
Type ✨
Tests 🛠️
Will update soon