Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli npm release windows and symlink bugs #2732

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

DanielHougaard
Copy link
Contributor

Description 📣

While going over the NPM CLI port I found an issue with the Windows download, causing it to fail during Windows downloads due to a wrong extension format. I've added zip support to resolve this.

Additionally I also found a discrepancy with the symlink creation on global installations. This PR also resolves that issue.

This can be tested locally by CD'ing into the /npm folder and running

cd /npm
npm install -g .

whereis infisical # Should print a path pointing to a correctly symlinked path

Make sure to change the version field in the package.json file when doing a local test, since 0.0.0 is not a valid CLI version.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@DanielHougaard DanielHougaard self-assigned this Nov 14, 2024
@maidul98 maidul98 merged commit 9aebd71 into main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants