fix: cli npm release windows and symlink bugs #2732
Merged
+99
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
While going over the NPM CLI port I found an issue with the Windows download, causing it to fail during Windows downloads due to a wrong extension format. I've added zip support to resolve this.
Additionally I also found a discrepancy with the symlink creation on global installations. This PR also resolves that issue.
This can be tested locally by CD'ing into the /npm folder and running
Make sure to change the
version
field in thepackage.json
file when doing a local test, since 0.0.0 is not a valid CLI version.Type ✨