feat(webui localization): add support for pt-PT #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was dizzy and forgot to make a branch This reverts commit 43f9af1. Signed-off-by: Caio Gomes <ocaioluis@gmail.com>
vmatsiiako
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
@caioluis This looks really great!! Thank you so much! :)
Some parts of the app are still missing translations. We should probably update the main issue to let people know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
For reference, check the issue #181
This PR adds support for the European Portuguese. I chose some terms over others based on the number of results google.pt returns when we restrict the search within Portugal to give the best results. Things may still be improved, as many terms don't have an 1-to-1 translation.
Type ✨
Tests 🛠️
Ran local tests to verify any visual glitching. I hope I didn't lose anything in the process.