Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webui-localization): update and fix pt-BR #378

Merged
merged 2 commits into from
Mar 5, 2023

Conversation

caioluis
Copy link
Contributor

@caioluis caioluis commented Feb 25, 2023

Description 📣

For reference, check the issue #181

There were a few things in the Brazilian Portuguese version that seemed unnatural for me, especially some common used terms in Software Engineering (i.e.: "variáveis de ambientes" was being written as "variáveis ambientais" which means something totally unrelated to SWE).

Probably there are few things to tweak still, I'm not perfect, nobody is. Feel free to give your opinion if you are a fellow Brazilian.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

Trivial changes on the copies, nothing that I see that would break. I have visually tested still, tho.


vmatsiiako
vmatsiiako previously approved these changes Mar 5, 2023
Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I completely missed this PR! Appreciate your contribution a lot :)

@vmatsiiako vmatsiiako merged commit edc4382 into Infisical:main Mar 5, 2023
@caioluis caioluis deleted the fix/update-pt-br-copies branch March 6, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants