This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
improvement: report output readability #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, it might also be worthwhile to discuss copying npm's table style:
...or at least including equivalent information -- I find the dependency path trace to be helpful. |
InfoSec812
reviewed
Jul 12, 2019
|
@InfoSec812 bump! |
Sorry, I haven't had a chance to test it out and confirm. I will try to do that this morning. |
|
I tested it on a few projects and I am OK with this. One of the main concerns I has was to ensure it didn't break the JSON output option so that it could be piped to |
|
@shockey One last thing... Please bump the version in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a table report format, and makes the report messaging more helpful by repeating back the selected options to the user.
Context
I'm integrating
npm-audit-ci-wrapperin Swagger UI.This is the only module with the right combination of options for our purposes, but I found that vulnerability readouts were overflowing my (relatively-narrow) terminal window, and the static message coming back from the utility wasn't helpful in differentiating between the two runs we want to do for our audits.
Before
After