Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Issue 41: Fix issues with large audit data response #42

Merged

Conversation

InfoSec812
Copy link
Owner

Resolves #41

Description

For some projects, the data returned from npm audit --json can be quite significant in size. This change refactors the code to use command.spawn and a stream of data events, instead of command.exec and a fixed sized buffer. Allowing the stderr/stdout data to stream via events ensures that the application can handle much larger data structures.

This prevents a situation where an unusually large npm
audit response can get cut off and generate errors
@InfoSec812 InfoSec812 self-assigned this Oct 23, 2019
@InfoSec812 InfoSec812 merged commit 9113ae6 into master Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crashing with TypeError
1 participant