Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show downloads from private tabs in not private window #31

Closed
Infocatcher opened this issue Apr 12, 2013 · 0 comments
Closed

Show downloads from private tabs in not private window #31

Infocatcher opened this issue Apr 12, 2013 · 0 comments
Labels
enhancement

Comments

@Infocatcher
Copy link
Owner

Requested here: http://forums.mozillazine.org/viewtopic.php?p=12793367#p12793367

(And show downloads from normal tabs in private window.)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
Patcher: add ability to override function result
865a582 
And we should change wrapNS sinse we can't use old patches
(part 1 for #31)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
Override PrivateBrowsingUtils.isWindowPrivate() (globally!):
93e7887 
return private state of selected tab for calls from chrome://browser/content/downloads/downloads.js and resource://app/modules/DownloadsCommon.jsm
(part 2 for #31)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
Try update download button and panel
eb071f0 
if selected tab changed from not private to private (and vice versa)
Note: progress indication are buggy
(part 3 for #31)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
Add "patchDownloads" preference: hack for downloads may break many th…
1a1d397 
…ings..

(part 4 for #31)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
Downloads: nothing to do with browser.download.useToolkitUI == true
4a20e84 
(part 5 for #31)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
Downloads: handle Tools - Downloads and add support for Firefox 20
cf0b7e1 
(part 6 for #31)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
We can leave wrapNS unchanged: new ability to override returned value…
71ff532 
… used only in new patch

(part 7 for #31)
Infocatcher added a commit that referenced this issue Apr 15, 2013
@Infocatcher
Hack: try update download indicator, if private state of selected tab…
8d045e7 
… was changed

(part 8 for #31)
Infocatcher added a commit that referenced this issue Apr 16, 2013
@Infocatcher
Download indicator: correctly work with multiple windows
10e05b0 
(part 9 for #31)
Infocatcher added a commit that referenced this issue Apr 18, 2013
@Infocatcher
Do nothing, if DownloadsIndicatorView not yet initialized
27ed558 
(part 10 for #31)
Infocatcher added a commit that referenced this issue Apr 18, 2013
@Infocatcher
Correctly reinitialize DownloadsPanel
c85241f 
(part 11 for #31)
Infocatcher added a commit that referenced this issue Apr 21, 2013
@Infocatcher
Patcher: allow eval-patches for modules without global window object
1e9398b 
(part 12 for #31)
Infocatcher added a commit that referenced this issue Apr 21, 2013
@Infocatcher
Set "patchDownloads" preference to false in SeaMonkey:
20c7345 
built-in download manager aren't support private browsing at all
(part 13 for #31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Infocatcher