Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with NoSquint 2.1.9 #61

Closed
streetwolf opened this issue May 15, 2013 · 2 comments
Closed

Conflict with NoSquint 2.1.9 #61

streetwolf opened this issue May 15, 2013 · 2 comments

Comments

@streetwolf
Copy link

NoSquint has an option called 'Global Settings'. With Private Tabs enabled the 'Global Settings' menu is not fully displayed. Only the OK, Cancel, and Help buttons are shown. Can you have a look into this?

NoSquint: Firefox Extension - https://urandom.ca/nosquint/

Someone else filed a bug report about this problem over at NoSquint:

Private Tab 0.1.1 breaks NoSquint Options · Issue #80 · jtackaberry/nosquint - jtackaberry/nosquint#80

@Infocatcher
Copy link
Owner

Seems like
https://github.com/jtackaberry/nosquint/blob/2.1.9/src/content/prefs.js#L15

this.isPrivate = isWindowPrivate();

is called too early (may also cause jtackaberry/nosquint#73).
And Private Tab overrides PrivateBrowsingUtils.isWindowPrivate() and checks window.document.documentElement:
https://github.com/Infocatcher/Private_Tab/blob/0.1.2/bootstrap.js#L2161
=> https://github.com/Infocatcher/Private_Tab/blob/0.1.2/bootstrap.js#L272

And strange things happens, if window.document.readyState == "uninitialized".

@Infocatcher
Copy link
Owner

Looks fixed for me after d6ead0d commit.

Test version: private_tab-0.1.3pre3-fx-sm.xpi (source)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants