Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility problem with TabMixPlus multi-row feature #95

Closed
ntv1000 opened this issue Aug 29, 2013 · 7 comments
Closed

Compatibility problem with TabMixPlus multi-row feature #95

ntv1000 opened this issue Aug 29, 2013 · 7 comments

Comments

@ntv1000
Copy link

ntv1000 commented Aug 29, 2013

When using the multi-row feature of TabMixPlus (latest (dev) build today) with 3 or more rows Private Tab enabled, an empty tab-row appears like in the attatched image. (Firefox 23.0.1, tested with clean profile)
privatetabproblem

@Infocatcher
Copy link
Owner

Can't reproduce. May be OS-specific...
I think, this may be caused by "New Private Tab" button after last tab (is this bug exists in Private Tab 0.1.3?).
Please try following style for userChrome.css:

#privateTab-afterTabs-openNewPrivateTab {
    display: none !important;
}

– may be I can just use this to hide it instead of visibility: collapse.

And please report this also to Tab Mix Plus developers.

@ntv1000
Copy link
Author

ntv1000 commented Aug 30, 2013

Both solutions you suggested fix the problem. Thank you for your time! Reported it to the TabMixPlus developers, too.

@Infocatcher
Copy link
Owner

This style isn't complete solution, just a test, I used more complex styles:
https://github.com/Infocatcher/Private_Tab/blob/0.1.5/bootstrap.js#L2809
(and I see another issue with Tab Mix Plus: #96)
So I can modify my styles, but the same may happens with Tab Mix Plus and any other extension with collapsed things on tabs level. If this can be fixed from TMP side, it's better to do it there.

Reported it to the TabMixPlus developers, too.

Thanks. The link should be also here: https://bitbucket.org/onemen/tabmixplus/issue/11/compatibility-problem-of-multi-row-feature

@onemen
Copy link

onemen commented Sep 1, 2013

Look like both #95 and #96 caused by the same problem.
privateTab-afterTabs-openNewPrivateTab isn't visible after tabs probably since tabmixScrollBox come between the button and new-tab-button on tabbrowser-tabs.

Did you fix issue #96, how can i download and test the extensions with the new patch ?

In multi-row i have special css rules to make sure that .tabbrowser-arrowscrollbox > .tabs-newtab-button is not visible, event if tabs are not overflow, if the button don't have space to be on the same row with the last tab.

Now, when there are two button this is event more complicating

It is simpler to apply the rules that hide the button on overflow also when there are more then one row

@Infocatcher
Copy link
Owner

Did you fix issue #96, how can i download and test the extensions with the new patch ?

Sorry, only source code available...
4ca9d51 => Browse code => Download ZIP
(Or https://github.com/Infocatcher/Private_Tab => commits => Browse code for some commit)
But unfortunately downloaded code should be repacked to place install.rdf in ZIP archive's root.

Anyway, I uploaded "ready" xpi: #96 (comment)

@ntv1000
Copy link
Author

ntv1000 commented Sep 3, 2013

try the test version
https://bitbucket.org/onemen/tabmixplus/downloads/tab_mix_plus-0.4.1.1pre.130821b-privateTabs-compatibility-test.xpi

Tested this version and can verify that it solves the compatibility problem. I can only say thank you both, since I like the combination of these two extensions!

@ntv1000 ntv1000 closed this as completed Sep 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants