chore: Avoid Sonar lint complexity code

Infomaniak · Jan 31, 2025 · 5f6e02d · 5f6e02d
1 parent 847b537
commit 5f6e02d
Showing 1 changed file with 24 additions and 23 deletions.
diff --git a/app/src/main/java/com/infomaniak/mail/utils/LoginUtils.kt b/app/src/main/java/com/infomaniak/mail/utils/LoginUtils.kt
@@ -17,6 +17,7 @@
  */
 package com.infomaniak.mail.utils
 
+import android.content.Context
 import androidx.activity.result.ActivityResult
 import androidx.appcompat.app.AppCompatActivity
 import androidx.fragment.app.Fragment
@@ -100,37 +101,37 @@ class LoginUtils @Inject constructor(
 
         val context = requireContext()
 
-        suspend fun loginSuccess(user: User) {
-            context.trackAccountEvent("loggedIn")
-            ioDispatcher {
-                mailboxController.getFirstValidMailbox(user.id)?.mailboxId?.let { AccountUtils.currentMailboxId = it }
-            }
-            AccountUtils.reloadApp?.invoke()
+        when (val returnValue = LoginActivity.authenticateUser(context, apiToken, mailboxController)) {
+            is User -> return@launch context.loginSuccess(returnValue)
+            is MailboxErrorCode -> context.mailboxError(returnValue)
+            is ApiResponse<*> -> context.apiError(returnValue)
+            else -> context.otherError()
         }
 
-        suspend fun mailboxError(errorCode: MailboxErrorCode) = withContext(mainDispatcher) {
-            when (errorCode) {
-                MailboxErrorCode.NO_MAILBOX -> context.launchNoMailboxActivity()
-                MailboxErrorCode.NO_VALID_MAILBOX -> context.launchNoValidMailboxesActivity()
-            }
-        }
+        logout(infomaniakLogin, apiToken)
+    }
 
-        suspend fun apiError(apiResponse: ApiResponse<*>) = withContext(mainDispatcher) {
-            showError(context.getString(apiResponse.translatedError))
+    private suspend fun Context.loginSuccess(user: User) {
+        trackAccountEvent("loggedIn")
+        ioDispatcher {
+            mailboxController.getFirstValidMailbox(user.id)?.mailboxId?.let { AccountUtils.currentMailboxId = it }
         }
+        AccountUtils.reloadApp?.invoke()
+    }
 
-        suspend fun otherError() = withContext(mainDispatcher) {
-            showError(context.getString(R.string.anErrorHasOccurred))
+    private suspend fun Context.mailboxError(errorCode: MailboxErrorCode) {
+        when (errorCode) {
+            MailboxErrorCode.NO_MAILBOX -> launchNoMailboxActivity()
+            MailboxErrorCode.NO_VALID_MAILBOX -> launchNoValidMailboxesActivity()
         }
+    }
 
-        when (val returnValue = LoginActivity.authenticateUser(context, apiToken, mailboxController)) {
-            is User -> return@launch loginSuccess(returnValue)
-            is MailboxErrorCode -> mailboxError(returnValue)
-            is ApiResponse<*> -> apiError(returnValue)
-            else -> otherError()
-        }
+    private suspend fun Context.apiError(apiResponse: ApiResponse<*>) = withContext(mainDispatcher) {
+        showError(getString(apiResponse.translatedError))
+    }
 
-        logout(infomaniakLogin, apiToken)
+    private suspend fun Context.otherError() = withContext(mainDispatcher) {
+        showError(getString(R.string.anErrorHasOccurred))
     }
 
     private suspend fun logout(infomaniakLogin: InfomaniakLogin, apiToken: ApiToken) {