Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add scheduled Drafts #2143

Merged
merged 70 commits into from
Feb 10, 2025
Merged

feat: Add scheduled Drafts #2143

merged 70 commits into from
Feb 10, 2025

Conversation

TommyDL-Infomaniak
Copy link
Contributor

@TommyDL-Infomaniak TommyDL-Infomaniak commented Jan 23, 2025

This feature is behind a feature flag, and lacks the ability to delete scheduled messages for now (due to how the API deletes scheduled messages).

Depends on Infomaniak/android-core#259

@TommyDL-Infomaniak TommyDL-Infomaniak added the feature Add a new function or capability to the project label Jan 23, 2025
@TommyDL-Infomaniak TommyDL-Infomaniak self-assigned this Jan 23, 2025
@github-actions github-actions bot added the dependent This MR depends on another PR label Jan 23, 2025
@github-actions github-actions bot removed the dependent This MR depends on another PR label Jan 23, 2025
Copy link

This PR/issue depends on:

@KevinBoulongne KevinBoulongne force-pushed the ft/schedule-send branch 4 times, most recently from 55e8b34 to 2a8156c Compare January 24, 2025 16:52
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments, the rest will come later

app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-es/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-es/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-de/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-de/strings.xml Show resolved Hide resolved
@KevinBoulongne KevinBoulongne force-pushed the ft/schedule-send branch 2 times, most recently from 9d8fa57 to 3c2c55c Compare January 30, 2025 10:19
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments for now

Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next comments

app/src/main/res/navigation/main_navigation.xml Outdated Show resolved Hide resolved
@KevinBoulongne KevinBoulongne force-pushed the ft/schedule-send branch 4 times, most recently from 29ae022 to dba74e5 Compare January 30, 2025 12:12
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments

gradle/libs.versions.toml Outdated Show resolved Hide resolved
app/src/main/res/layout/item_message.xml Outdated Show resolved Hide resolved
@KevinBoulongne KevinBoulongne force-pushed the ft/schedule-send branch 6 times, most recently from f77ba3e to d52e821 Compare January 30, 2025 13:56
@KevinBoulongne KevinBoulongne dismissed LunarX’s stale review February 10, 2025 11:49

He approved to me verbally.

@KevinBoulongne KevinBoulongne merged commit 9beccd7 into master Feb 10, 2025
6 checks passed
@KevinBoulongne KevinBoulongne deleted the ft/schedule-send branch February 10, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add a new function or capability to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants