Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use ngModel with material_select #3

Closed
jseriff opened this issue Feb 23, 2016 · 3 comments
Closed

Cannot use ngModel with material_select #3

jseriff opened this issue Feb 23, 2016 · 3 comments

Comments

@jseriff
Copy link

jseriff commented Feb 23, 2016

When using material_select, ngModel no longer works for binding the value
rubyboy added a commit that referenced this issue Feb 24, 2016
@rubyboy
fix(select): Fixed select with ngModel (issue #3)
70a1b09 
#3
rubyboy added a commit that referenced this issue Feb 24, 2016
@rubyboy
fix(select): Fixed select problem with ngModel + binding events properly
fe8933c 
#3
@rubyboy
Copy link
Contributor

rubyboy commented Feb 24, 2016

@jseriff thanks for reporting this problem. Appreciate it.
This is fixed now. Could you please confirm?
I've also added usage of [(ngModel)] to the example app to illustrate how that would work.

@jseriff
Copy link
Author

jseriff commented Feb 24, 2016

@rubyboy Seems to work now, thanks. However, the typescript compiler is complaining because ngDoCheck and ngAfterViewInit should not be private (their corrosponding interfaces have them public).

@rubyboy
Copy link
Contributor

rubyboy commented Feb 24, 2016

Oh, thanks. I was under the impression omitting the modifier would default it to public.
Anyhow, I've fixed that as well. Thanks!

@rubyboy rubyboy closed this as completed Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jseriff @rubyboy