Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search content pages #111

Merged
merged 11 commits into from
Jul 18, 2024
Merged

search content pages #111

merged 11 commits into from
Jul 18, 2024

Conversation

NilsOveTen
Copy link
Contributor

KjerstiSteien
KjerstiSteien reviewed Jul 17, 2024
View reviewed changes
content/Felles datakatalog/Search/Search/_index.md Outdated

### Boosting

Hits from some fields will be prioritized over others, i.e. a matching hit from the title field will be prioritized over a hit from the description field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skulle vi lagt til lista over de søkbare feltenes vekting? Er det dokumentert et annet sted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan få lagt det inn her, ja. Tror ikke det er dokumentert noe sted ut over koden

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

220a04f

content/Felles datakatalog/Search/Search/_index.md Outdated

### Pagination

All search results will be paginated, it is possible to manipulate the size and page number with the pagination field in the search body.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hva innebærer det å manipulere size på søkeresultatet?

Jeg prøvde å google meg frem. Er det page size som menes? "Page size denotes the number of records in each page." I så fall, hvorfor er tallet 1 i eksempelet? Hva representerer dette tallet, hvis det ikke representerer antall treff på hver side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size er antall treff per side, ja. Så når jeg har ´"size": 1´i eksempelet så lager den en side per treff

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da foreslår jeg å endre til "size":10 eller høyere i eksempelet, det gjør det lettere å forstå.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

216e656

content/Felles datakatalog/Search/Search/_index.md Outdated Show resolved Hide resolved
content/Felles datakatalog/Search/Search/_index.md Outdated

Example using the open data filter:
```Shell
curl -X POST 'https://search.api.staging.fellesdatakatalog.digdir.no/search' -H 'Content-Type: application/json' -d '{"query":"test","filters":{"openData":{"value":true}}}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har vi en binærverdi for åpne data? Hva er den basert på? Og hvordan spiller den sammen med disse filtrene?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasoning-service setter en binærverdi på om et datasett er åpne data eller ikke

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ett av kravene som den bruker er at datasettet har allmenn tilgang, så alle datasett som er type åpne data har allmenn tilgang, men ikke alt med allmenn tilgang er åpne data

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skjønner. Den informasjonen hadde det vært fint å fremme et sted, Kanskje på en av infosidene i katalogen, så man lettere forstår hva filtrene representerer.

content/Felles datakatalog/Search/Search/_index.md Outdated Show resolved Hide resolved
content/Felles datakatalog/Search/_index.md Outdated Show resolved Hide resolved
content/Felles datakatalog/Search/_index.md Outdated Show resolved Hide resolved
content/Felles datakatalog/Search/_index.md Outdated

### Search

The main search service in Data.norge.no is based on ElasticSearch. This service only searches the text in a few fields, but has filters and other advanced functionality that helps users navigate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skulle vi vist til dokumentasjon som lister opp feltene man kan søke på? Eller gjør vi det per katalog et annet sted? Lenke eller henvise mellom disse sidene når det er på plass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i den tjenesten mapper vi alle ressurstypene over til en generisk modell, så det er de samme feltene for hver type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

og selv om vi ikke bruker det i portal per nå så er det mulig å definere hvilke av de 3 feltene en vil søke i, kan få inn litt info om det i hovedsida til search-service og legge til link herfra

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

220a04f

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

og 138fc0e

content/Felles datakatalog/Search/_index.md Outdated
### LLM

The LLM search service uses a 'Large Language Model' (LLM) that is built from the same data used in the main search, but will accept naturally worded queries where the other search demands exact wording of titles or keywords.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lenke til side som gir mer detaljert info om LLM når dette er på plass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

138fc0e

content/Felles datakatalog/Search/_index.md Outdated

### SPARQL

The SPARQL search service is based on the RDF query language SPARQL, and is our most advanced and powerful search. A user will have to create queries that follows the correct syntax, but will be able to search all harvested data points, not just pre-selected fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lenke til SPARQL-side for mer info?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

138fc0e

KjerstiSteien
KjerstiSteien approved these changes Jul 18, 2024
View reviewed changes
content/Felles datakatalog/Search/Search/_index.md Outdated

| Field | Boost |
| ------ | ------ |
| title, partial match | 15 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foreslår å bytte plass på de to øverste vektingene, så det blir lettere å lese. Fra høyest til lavest vekt.

Suggested change
| title, partial match | 15 |
| title, full phrase match | 30 |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2f17e35

NilsOveTen and others added 10 commits July 18, 2024 15:31
@NilsOveTen
search content pages
84c3f72
@NilsOveTen @KjerstiSteien
Update content/Felles datakatalog/Search/Search/_index.md
305a1c6 
Co-authored-by: KjerstiSteien <110605570+KjerstiSteien@users.noreply.github.com>
@NilsOveTen @KjerstiSteien
Update content/Felles datakatalog/Search/Search/_index.md
d4a92a2 
Co-authored-by: KjerstiSteien <110605570+KjerstiSteien@users.noreply.github.com>
@NilsOveTen @KjerstiSteien
Update content/Felles datakatalog/Search/_index.md
dcdf08f 
Co-authored-by: KjerstiSteien <110605570+KjerstiSteien@users.noreply.github.com>
@NilsOveTen @KjerstiSteien
Update content/Felles datakatalog/Search/_index.md
e03a09e 
Co-authored-by: KjerstiSteien <110605570+KjerstiSteien@users.noreply.github.com>
@NilsOveTen
searchable fields
dad0394
@NilsOveTen
boosting table sorted
e0dc14e
@NilsOveTen
links from main search page
831cfd4
@NilsOveTen
update pagination example
1c796b0
@NilsOveTen
aggregations
e3e2a3d
@NilsOveTen NilsOveTen force-pushed the search-and-filter branch 2 times, most recently from 618509a to 0bda00d Compare July 18, 2024 13:50
@NilsOveTen NilsOveTen merged commit 4bee46d into master Jul 18, 2024
@NilsOveTen NilsOveTen deleted the search-and-filter branch July 18, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KjerstiSteien KjerstiSteien KjerstiSteien approved these changes

@Lillebo Lillebo Awaiting requested review from Lillebo

@AinaEngen AinaEngen Awaiting requested review from AinaEngen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dokumentere søk
2 participants
@NilsOveTen @KjerstiSteien