-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: frontpage/data-hunter sync #153
Conversation
b646598
to
a55c39d
Compare
67239c1
to
c9bee59
Compare
apps/frontpage/src/app/[lang]/components/orakel-search/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det virker som indenteringen i noen av filene er satt til 8 spaces, eller 1 tab (med bredde lik 8 spaces). Følger det lint-reglene i repoet? Tror vi har pleid å ha 4 spaces i de andre prosjektene. Hva skjer om du kjører lint på hele prosjektet, blir det autoformatert riktig da?
@@ -12,15 +12,15 @@ export default class FormPage { | |||
formData = {}; | |||
|
|||
constructor(page: Page, context: BrowserContext, accessibilityBuilder?: AxeBuilder) { | |||
getDictionary('en', 'data-hunter-page').then((dict) => (this.dictionary = dict)); | |||
getDictionary('en').then((dict) => (this.dictionary = dict)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er engelsk default valg her? Burde det være bokmål?
test('should not have any automatically detectable accessibility issues', async ({ dataHunterFormPage }) => { | ||
await dataHunterFormPage.checkAccessibility(); | ||
}); | ||
// import { test } from '../fixtures/basePage'; | ||
|
||
test('check page text', async ({ dataHunterFormPage }) => { | ||
await dataHunterFormPage.checkPageTitleText(); | ||
await dataHunterFormPage.checkPageDescriptionText(); | ||
}); | ||
// test('should not have any automatically detectable accessibility issues', async ({ dataHunterFormPage }) => { | ||
// await dataHunterFormPage.checkAccessibility(); | ||
// }); | ||
|
||
test('fill and submit form', async ({ dataHunterFormPage }) => { | ||
await dataHunterFormPage.fillForm(); | ||
await dataHunterFormPage.submitForm(); | ||
}); | ||
*/ No newline at end of file | ||
// test('check page text', async ({ dataHunterFormPage }) => { | ||
// await dataHunterFormPage.checkPageTitleText(); | ||
// await dataHunterFormPage.checkPageDescriptionText(); | ||
// }); | ||
|
||
// test('fill and submit form', async ({ dataHunterFormPage }) => { | ||
// await dataHunterFormPage.fillForm(); | ||
// await dataHunterFormPage.submitForm(); | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slette om ikke skal brukes
libs/ui/src/lib/language-switcher/language-switcher.stories.tsx
Outdated
Show resolved
Hide resolved
9f85827
to
682bbde
Compare
5c71bd6
to
f749808
Compare
7d83c50
to
a01d037
Compare
a01d037
to
c56ccb4
Compare
c39dfec
to
cba02d4
Compare
apps/frontpage/src/app/[lang]/components/frontpage-banner/components/scroll-button/index.tsx
Outdated
Show resolved
Hide resolved
...rc/app/[lang]/components/frontpage-banner/components/scroll-button/scroll-button.module.scss
Outdated
Show resolved
Hide resolved
…ight, and to disappear when user scrolls past
Denne er allerede merget av #164 |
Resolves #130 #132 #138 #158 #159 https://github.com/Informasjonsforvaltning/fdk-team-private/issues/94 https://github.com/Informasjonsforvaltning/fdk-team-private/issues/87