feat: frontpage/data-hunter sync #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreiffers
force-pushed
the
feat/data-hunter-sync
branch
from
b646598
to
a55c39d
Compare
Lillebo
force-pushed
the
feat/data-hunter-sync
branch
from
67239c1
to
c9bee59
Compare
NilsOveTen
approved these changes
Aug 14, 2024
apps/frontpage/src/app/[lang]/components/orakel-search/index.tsx
Outdated
Show resolved
Hide resolved
terjesyl
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Det virker som indenteringen i noen av filene er satt til 8 spaces, eller 1 tab (med bredde lik 8 spaces). Følger det lint-reglene i repoet? Tror vi har pleid å ha 4 spaces i de andre prosjektene. Hva skjer om du kjører lint på hele prosjektet, blir det autoformatert riktig da?
| @@ -12,15 +12,15 @@ export default class FormPage { | |||
| formData = {}; | |||
|
|
|||
| constructor(page: Page, context: BrowserContext, accessibilityBuilder?: AxeBuilder) { | |||
| getDictionary('en', 'data-hunter-page').then((dict) => (this.dictionary = dict)); | |||
| getDictionary('en').then((dict) => (this.dictionary = dict)); | |||
There was a problem hiding this comment.
Er engelsk default valg her? Burde det være bokmål?
Comment on lines
8
to
22
| test('should not have any automatically detectable accessibility issues', async ({ dataHunterFormPage }) => { | ||
| await dataHunterFormPage.checkAccessibility(); | ||
| }); | ||
| // import { test } from '../fixtures/basePage'; | ||
|
|
||
| test('check page text', async ({ dataHunterFormPage }) => { | ||
| await dataHunterFormPage.checkPageTitleText(); | ||
| await dataHunterFormPage.checkPageDescriptionText(); | ||
| }); | ||
| // test('should not have any automatically detectable accessibility issues', async ({ dataHunterFormPage }) => { | ||
| // await dataHunterFormPage.checkAccessibility(); | ||
| // }); | ||
|
|
||
| test('fill and submit form', async ({ dataHunterFormPage }) => { | ||
| await dataHunterFormPage.fillForm(); | ||
| await dataHunterFormPage.submitForm(); | ||
| }); | ||
| */ No newline at end of file | ||
| // test('check page text', async ({ dataHunterFormPage }) => { | ||
| // await dataHunterFormPage.checkPageTitleText(); | ||
| // await dataHunterFormPage.checkPageDescriptionText(); | ||
| // }); | ||
|
|
||
| // test('fill and submit form', async ({ dataHunterFormPage }) => { | ||
| // await dataHunterFormPage.fillForm(); | ||
| // await dataHunterFormPage.submitForm(); | ||
| // }); |
libs/ui/src/lib/language-switcher/language-switcher.stories.tsx
Outdated
Show resolved
Hide resolved
terjesyl
reviewed
Aug 15, 2024
Lillebo
force-pushed
the
feat/data-hunter-sync
branch
from
9f85827
to
682bbde
Compare
jeffreiffers
force-pushed
the
feat/data-hunter-sync
branch
from
5c71bd6
to
f749808
Compare
jeffreiffers
force-pushed
the
feat/data-hunter-sync
branch
2 times, most recently
from
7d83c50
to
a01d037
Compare
jeffreiffers
force-pushed
the
feat/data-hunter-sync
branch
from
a01d037
to
c56ccb4
Compare
jeffreiffers
force-pushed
the
feat/data-hunter-sync
branch
from
c39dfec
to
cba02d4
Compare
terjesyl
approved these changes
Aug 22, 2024
apps/frontpage/src/app/[lang]/components/frontpage-banner/components/scroll-button/index.tsx
Outdated
Show resolved
Hide resolved
...rc/app/[lang]/components/frontpage-banner/components/scroll-button/scroll-button.module.scss
Outdated
Show resolved
Hide resolved
…ight, and to disappear when user scrolls past
|
Denne er allerede merget av #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130 #132 #138 #158 #159 https://github.com/Informasjonsforvaltning/fdk-team-private/issues/94 https://github.com/Informasjonsforvaltning/fdk-team-private/issues/87