Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support dbt 1.7 #929

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Nov 21, 2023

Fix #928

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
feature

What this PR does / why we need it:

  • to support dbt 1.7

Which issue(s) this PR fixes:
sc-32598

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@wcchang1115 wcchang1115 changed the title Support dbt 1.7 metric filter format [Feature] Support dbt 1.7 metric filter format Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ad3ce42) 48.49% compared to head (2ca7a73) 48.48%.

Files Patch % Lines
piperider_cli/dbtutil.py 66.66% 8 Missing ⚠️
piperider_cli/dbt/list_task.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   48.49%   48.48%   -0.01%     
==========================================
  Files          63       63              
  Lines        9067     9081      +14     
==========================================
+ Hits         4397     4403       +6     
- Misses       4670     4678       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It has been fixed and backported to 1.6.2

Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@wcchang1115 wcchang1115 changed the title [Feature] Support dbt 1.7 metric filter format [Feature] Support dbt 1.7 Nov 21, 2023
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@wcchang1115 wcchang1115 force-pushed the feature/sc-32598/piperider-support-dbt-1-7 branch from a43bf82 to 2ca7a73 Compare November 21, 2023 09:25
@wcchang1115 wcchang1115 marked this pull request as ready for review November 21, 2023 09:58
@wcchang1115 wcchang1115 merged commit 7a9cb3e into main Nov 22, 2023
30 checks passed
@wcchang1115 wcchang1115 deleted the feature/sc-32598/piperider-support-dbt-1-7 branch November 22, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for dbt-core~1.7.0
2 participants