apply reviews

Inist-CNRS · Oct 19, 2023 · 511d3c4 · 511d3c4
1 parent b1fbe1e
commit 511d3c4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 94 deletions.
diff --git a/src/api/controller/api/precomputed.js b/src/api/controller/api/precomputed.js
@@ -39,15 +39,10 @@ export const postPrecomputed = async ctx => {
 };
 
 export const putPrecomputed = async (ctx, id) => {
-    const newResource = ctx.request.body;
+    const newPrecomputed = ctx.request.body;
 
     try {
-        // Delete existing data from dataset
-        // If we change the name or the rule, existing data is obsolete
-        const precomputed = await ctx.precomputed.findOneById(id);
-        await ctx.dataset.removeAttribute(precomputed.name);
-
-        ctx.body = await ctx.precomputed.update(id, newResource);
+        ctx.body = await ctx.precomputed.update(id, newPrecomputed);
     } catch (error) {
         ctx.status = 403;
         ctx.body = { error: error.message };
@@ -57,7 +52,6 @@ export const putPrecomputed = async (ctx, id) => {
 
 export const deletePrecomputed = async (ctx, id) => {
     try {
-        const precomputed = await ctx.precomputed.findOneById(id);
         const activeJob = await getActiveJob(ctx.tenant);
         if (
             activeJob?.data?.jobType === PRECOMPUTER &&
@@ -66,7 +60,6 @@ export const deletePrecomputed = async (ctx, id) => {
             cancelJob(ctx, PRECOMPUTER);
         }
         await ctx.precomputed.delete(id);
-        await ctx.dataset.removeAttribute(precomputed.name);
         ctx.status = 200;
         ctx.body = { message: 'ok' };
     } catch (error) {

diff --git a/src/api/services/precomputed/directPathMultipleValues.txt b/src/api/services/precomputed/directPathMultipleValues.txt
diff --git a/src/api/services/precomputed/directPathSingleValue.txt b/src/api/services/precomputed/directPathSingleValue.txt