Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay to show loading when changing facet #1705

Merged
merged 9 commits into from
Nov 6, 2023
Merged

Conversation

AlasDiablo
Copy link
Collaborator

@AlasDiablo AlasDiablo commented Sep 18, 2023

Screenshot_20230919_085910

@AlasDiablo AlasDiablo marked this pull request as draft September 18, 2023 13:55
@AlasDiablo AlasDiablo self-assigned this Sep 18, 2023
@AlasDiablo AlasDiablo changed the title Add verlay to show loading when changing facet Add overlay to show loading when changing facet Sep 19, 2023
@AlasDiablo AlasDiablo marked this pull request as ready for review October 3, 2023 06:35
@AlasDiablo AlasDiablo added enhancement 👷‍♂️ Ready For Review PR en attente de relecture et de validation labels Oct 3, 2023
@AlasDiablo AlasDiablo marked this pull request as draft October 6, 2023 08:01
@touv
Copy link
Contributor

touv commented Oct 6, 2023

Cette PR pourrait être mergée, pourquoi est-elle en draft ?

@parmentf
Copy link
Contributor

parmentf commented Oct 9, 2023

Je suppose que c'est à cause du test-e2e qui est encore rouge.

@AlasDiablo AlasDiablo added help wanted and removed 👷‍♂️ Ready For Review PR en attente de relecture et de validation labels Oct 10, 2023
@AlasDiablo AlasDiablo marked this pull request as ready for review October 19, 2023 08:03
@AlasDiablo AlasDiablo added 👷‍♂️ Ready For Review PR en attente de relecture et de validation and removed help wanted labels Oct 19, 2023
@parmentf parmentf added 👷‍♂️ Ready To Merge PR relue et validée, prête à intégrer and removed 👷‍♂️ Ready For Review PR en attente de relecture et de validation labels Oct 19, 2023
@arimet arimet merged commit 3b6d674 into master Nov 6, 2023
@parmentf parmentf deleted the loading-overlay branch November 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready To Merge PR relue et validée, prête à intégrer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants