Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 16 #1715

Merged
merged 21 commits into from
Oct 19, 2023
Merged

Update to node 16 #1715

merged 21 commits into from
Oct 19, 2023

Conversation

AlasDiablo
Copy link
Collaborator

No description provided.

@AlasDiablo AlasDiablo marked this pull request as draft September 27, 2023 09:44
@parmentf
Copy link
Contributor

#11 98.76 > transformers@1.4.4 build
#11 98.76 > babel --root-mode upward src --out-dir lib
#11 98.76 
#11 99.04 Error: Babel was run with rootMode:"upward" but a root could not be found when searching upward from "/app/packages/transformers".
#11 99.04 One of the following config files must be in the directory tree: "babel.config.js, babel.config.cjs, babel.config.mjs, babel.config.json".

Possible that the error comes from the fact the @ezs/transformers was in a monorepo, where the babel.config.js is at the root of the repo.

@AlasDiablo AlasDiablo marked this pull request as ready for review October 10, 2023 05:35
@AlasDiablo AlasDiablo added the 👷‍♂️ Ready For Review PR en attente de relecture et de validation label Oct 10, 2023
Copy link
Contributor

@touv touv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use strict version

@AlasDiablo
Copy link
Collaborator Author

use strict version

Those change will be override by #1719

@parmentf parmentf added 👷‍♂️ Ready To Merge PR relue et validée, prête à intégrer and removed 👷‍♂️ Ready For Review PR en attente de relecture et de validation labels Oct 19, 2023
@touv touv merged commit d87dcb1 into master Oct 19, 2023
9 checks passed
@touv touv deleted the node-16 branch October 19, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready To Merge PR relue et validée, prête à intégrer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants