-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add dnd support in composed field #1870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adguernier
added
👷♂️ Work In Progress
PR en cours de développement
👷♂️ Do Not Merge
PR bloquée ne devant pas être intégrée
labels
Jan 29, 2024
adguernier
added
👷♂️ Ready For Review
PR en attente de relecture et de validation
and removed
👷♂️ Work In Progress
PR en cours de développement
👷♂️ Do Not Merge
PR bloquée ne devant pas être intégrée
labels
Jan 30, 2024
adguernier
commented
Jan 30, 2024
}); | ||
const style = { | ||
transform: CSS.Transform.toString(transform), | ||
transition: 'transform 0ms ease', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround for: clauderic/dnd-kit#833
slax57
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that it works great! Well done!
slax57
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add Drag N Drop support in composed field to allow users reorder tags
Capture.video.du.30-01-2024.12.39.05.webm