Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add dnd support in composed field #1870

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

adguernier
Copy link
Collaborator

@adguernier adguernier commented Jan 29, 2024

This PR attempts to add Drag N Drop support in composed field to allow users reorder tags

Capture.video.du.30-01-2024.12.39.05.webm

@adguernier adguernier added 👷‍♂️ Work In Progress PR en cours de développement 👷‍♂️ Do Not Merge PR bloquée ne devant pas être intégrée labels Jan 29, 2024
@adguernier adguernier added 👷‍♂️ Ready For Review PR en attente de relecture et de validation and removed 👷‍♂️ Work In Progress PR en cours de développement 👷‍♂️ Do Not Merge PR bloquée ne devant pas être intégrée labels Jan 30, 2024
});
const style = {
transform: CSS.Transform.toString(transform),
transition: 'transform 0ms ease',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround for: clauderic/dnd-kit#833

Copy link
Collaborator

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that it works great! Well done!

src/app/js/fields/FieldComposedOf.js Outdated Show resolved Hide resolved
src/app/js/fields/FieldComposedOf.js Outdated Show resolved Hide resolved
@slax57 slax57 merged commit 08ef37e into master Jan 30, 2024
9 checks passed
@slax57 slax57 deleted the feat/dnd-in-field-composed-of branch January 30, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants