Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an options to open a chart in fullscreen #1924

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Add an options to open a chart in fullscreen #1924

merged 6 commits into from
Mar 25, 2024

Conversation

AlasDiablo
Copy link
Collaborator

@AlasDiablo AlasDiablo commented Mar 20, 2024 •
edited
Loading

  • Vega-Lite
  • Vega
  • Other chart (Complete the list below with a compatibility and percentage table.)
    • Network
    • BubbleChart
    • Streamgraph
    • ..
  • Issues
    • Some formats do not utilize the available space efficiently.
      • Network now work
      • Some other charts will require some changes to be used, but I cannot make those changes due to lack of information and testing.
    • The Vega and Vega-Lite charts are restricted to the provided aspect ratio.
      • These issues can be addressed for some charts with Update aspect ratio system #1923. However, it requires more work to ensure proper functionality. Like the previous issues, this needs more testing and feedback from users.

Note:
This feature can be validated and merged, but it is considered experimental and requires feedback to achieve the best results.

@AlasDiablo AlasDiablo marked this pull request as ready for review March 21, 2024 10:22
@AlasDiablo AlasDiablo added the 👷‍♂️ Ready For Review PR en attente de relecture et de validation label Mar 21, 2024
@AlasDiablo
Merge branch 'master' into feat/fullscreen-format
c3d2e86 
# Conflicts:
#	src/app/custom/translations.tsv
#	src/app/js/formats/utils/components/vega-component/VegaComponent.js
#	src/app/js/formats/utils/components/vega-lite-component/VegaLiteComponent.js
@touv touv merged commit a95bc13 into master Mar 25, 2024
9 checks passed
@touv touv deleted the feat/fullscreen-format branch March 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmentf parmentf parmentf approved these changes

Assignees
No one assigned
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlasDiablo @parmentf @HeleneCreusot @touv