Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify theme css and add tools to do it #2015

Closed
wants to merge 2 commits into from
Closed

Conversation

AlasDiablo
Copy link
Collaborator

@AlasDiablo AlasDiablo commented May 31, 2024

This pr follow my comment #2011 (comment) on the pr #2011.
I have also updated the wiki https://github.com/Inist-CNRS/lodex/wiki/Theming-LODEX#css-minification.

@parmentf parmentf changed the title Mimify theme css and add tools to do it Minify theme css and add tools to do it May 31, 2024
package.json Outdated Show resolved Hide resolved
src/app/custom/themes/istex-legacy/index.html Show resolved Hide resolved
Copy link
Contributor

@touv touv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but at the least, the call to command should be automated. Without this, it will be difficult to know that changes will not be active. By the way, how can webmasters test their modifications without install lodex (ezmaster)?

@AlasDiablo AlasDiablo closed this Jul 18, 2024
@AlasDiablo AlasDiablo deleted the css-mimify branch July 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants