Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move template variables into the LODEX dynamic config #2027

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Move template variables into the LODEX dynamic config #2027

merged 1 commit into from
Jun 12, 2024

Conversation

AlasDiablo
Copy link
Collaborator

@AlasDiablo AlasDiablo commented Jun 11, 2024 •
edited
Loading

TODO

  • Add the documentation into the wiki page

@AlasDiablo AlasDiablo added the 👷‍♂️ Ready For Review PR en attente de relecture et de validation label Jun 11, 2024
@AlasDiablo AlasDiablo requested a review from touv June 11, 2024 13:58
@AlasDiablo AlasDiablo self-assigned this Jun 11, 2024
@AlasDiablo
Copy link
Collaborator Author

The documentation has been updated to version 4 https://github.com/Inist-CNRS/lodex/wiki/Theming-LODEX

@AlasDiablo AlasDiablo requested a review from parmentf June 12, 2024 06:10
parmentf
parmentf approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@parmentf parmentf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but why change so often the themes' structure?

@touv touv merged commit f3847b2 into master Jun 12, 2024
9 checks passed
@touv touv deleted the refactor/theme/custom-variables branch June 12, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmentf parmentf parmentf approved these changes

@touv touv touv approved these changes

Assignees

@AlasDiablo AlasDiablo

Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlasDiablo @touv @parmentf