Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Application crashes when selecting "Mirrored Autofill" and "→", "↑" or "↓" in the parameter panel. #87

Closed
2 tasks done
seagetch opened this issue Oct 3, 2022 · 0 comments
Labels
Bug Something isn't working

Comments

@seagetch
Copy link
Contributor

seagetch commented Oct 3, 2022

Validations

  • I have checked for similar bug reports and could not find any.
  • I have tested and confirmed that this is an issue in an official branded build.

Describe the bug

When selecting "Mirrored Autofill" and "→(right)", "↑(up)" or "↓(down)" in the parameter panel, application crashed.
It is not crashed when select "←(left)".

Reproduction

  1. Open model
  2. Ensure model has parameter.
  3. Select "Mirrored Autofill" from parameter panel.
  4. Select "→", "↑" or "↓"

System Architecture

x86_64

Operating System

Linux

Version

nightly build. b4232c2 Update translation template

Logs

Application crashed with following dump.

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007f2272a06859 in __GI_abort () at abort.c:79
#2  0x00007f2272a06729 in __assert_fail_base (fmt=0x7f2272b9c588 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=0x564e0ec582a7 "window->IDStack.Size > 1", 
    file=0x564e0ec55460 "/home/seagetch/src/github/Inochi2D/bindbc-imgui/deps/cimgui/imgui/imgui.cpp", line=8048, 
    function=<optimized out>) at assert.c:92
#3  0x00007f2272a17fd6 in __GI___assert_fail (assertion=0x564e0ec582a7 "window->IDStack.Size > 1", 
    file=0x564e0ec55460 "/home/seagetch/src/github/Inochi2D/bindbc-imgui/deps/cimgui/imgui/imgui.cpp", line=8048, 
    function=0x564e0ec58293 "void ImGui::PopID()") at assert.c:101
#4  0x0000564e0d381cf8 in ImGui::PopID() ()
#5  0x0000564e0d34ea72 in igPopID ()
#6  0x0000564e0d3131a5 in _D7creator6panels10parameters__T16incParameterViewVbi0ZQxFmC8inochi2d4core5param9ParameterPAyabKAQBmS6inmath6linalg__T6VectorTfVii3ZQoZv (groupColor=..., paramArr=..., canGroup=false, grabParam=0x7f2271c01170, param=0x7f221d061160, idx=0)
    at source/creator/panels/parameters.d:532
#7  0x0000564e0d30e145 in creator.panels.parameters.ParametersPanel.onUpdate() (this=0x7f2271c01100)
    at source/creator/panels/parameters.d:925
#8  0x0000564e0d30831c in creator.panels.Panel.update() (this=0x7f2271c01100) at source/creator/panels/package.d:117
#9  0x0000564e0d30840a in creator.panels.incUpdatePanels() () at source/creator/panels/package.d:149
#10 0x0000564e0d237198 in app.incUpdate() () at source/app.d:122
#11 0x0000564e0d237115 in D main (args=...) at source/app.d:91

Additional Context

No response

@seagetch seagetch added the Bug Something isn't working label Oct 3, 2022
LunaTheFoxgirl pushed a commit that referenced this issue Oct 9, 2022
* Fixed bug (#80): Parameters in parameter group cannot be searchable.

* Fix bug (#89)
Recreate string for incInputText when it doesn't end with '\0'.

* Removes unused imports.

* Fixed wrong calculation of mesh and texture position in INP export.

* Cleanup code

* inputtext: Simplified string reconstruction with trailing '\0'.

* mesheditor: Fix bug that not deleting bindings in parameter groups on mesh vertex addition/removal.

* Fixed bug (#87) Application crashes when selecting "Mirrored Autofill"

Application crashed when selecting "Mirrored Autofill" and "→", "↑" or "↓" in the parameter panel.
This patch fixed the wrong index in Y axis, and also flipped the vertical range of mirroredAutofill to work same as horizontal case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants