multi-edit: Fix bugs: transformation matrix is not updated when T/R/S is changed during edit of armed parameter. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple parts are selected.
…/R/S is changed during edit of armed parameter.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multi-edit patch, I locked the transformation matrix when armed parameter is edited, which is required to enable path deformation for Node object.
This breaks consistency when T/R/S parameter is changed independently, and cursor position is not handled correctly.
This patch is a workaround to force update the transformation matrix when T/R/S is changed by calling IncMeshEditorOne.adjustPathTarget() for every mesh editors.
We need to call this method every time we changed the T/R/S parameter is changed when editing armed parameter in the future.