Add function to autosave the project #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunaTheFoxgirl
requested changes
Mar 30, 2023
|
I have addressed most of the comments. One thing I haven't figured out yet is how to elegantly load any of the autosaves displayed in the menu. See the TODO I added to |
|
I have completed the code for properly opening autosaves from the recents menu as well as implementing the user settings panel for controlling the autosave behavior. This is now ready for additional review. |
|
Could this PR be rebased on the latest commit? if so then I'll merge it @pankern |
|
Ok, I will rebase this feature on the latest from main. |
- Separated out most of the autosave code into seperate files. - Autosaves are now stored in the app data directory. - Added a buffer list of the recent autosaves. - Added a per-project lockfile to indicate if there may be data not yet saved to the main save file. - Changed the autosave file name to include date and time. - Added a popup window to prompt the user to restore from a backup when appropriate.
This is so that when we open an autosave from the recents menu, we can still correctly set the current project path to be the main save file instead of the autosave file, and the user can continue to press Ctrl+S to have changes saved in the expected location.
|
Rebase on the latest main is completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autosaves are implemented here in a rolling backup fashion, such that the 10 most recent autosaves are kept. The autosaves don't overwrite the main save file. The changes include modifying the
incSaveProjectfunction in order to avoid adding the autosave files to the list of previous projects.I thought it would be good to get this PR going with what I have now so I could incorporate feedback sooner rather than later.
Things not included in this PR that will likely still be needed: