Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize build scripts into build-aux #275

Merged
merged 2 commits into from
May 9, 2023

Conversation

grillo-delmal
Copy link
Contributor

Just thought that reordering the build scripts might help the repo to look neater. I basically created a build-aux folder and organized all the build helper scripts inside there.

@orowith2os suggested this to me on #272 for the files in that commit, but here I expanded it to the whole repo.

I'm just following my own compass on this, so feel free to close it if you don't like it or if you think this is unneeded.

Here is a more exhaustive list:

  • Created a ./build-aux folder
  • Moved build specific stuff from ./res/flatpak/ to ./build-aux/flatpak/
  • Moved windows specific build scripts from ./ to ./build-aux/windows/
  • Moved osx specific build scripts from ./ to ./build-aux/osx/
  • Moved linux specific build scripts from ./ to ./build-aux/linux
  • Moved translation helper scripts to ./ to ./build-aux
  • Fixed workflows to find scripts in their new home. Nightly result on this branch

Best regards and keep up the good work!

@github-actions github-actions bot added the Triage PR/Issue needs to be triaged. label May 9, 2023
@LunaTheFoxgirl LunaTheFoxgirl merged commit abc9d17 into Inochi2D:main May 9, 2023
@grillo-delmal grillo-delmal deleted the cleanup-build-scripts branch May 9, 2023 14:28
@orowith2os
Copy link
Contributor

Noting that the Flatpak desktop file can be moved to be used for all Linux stuff, as the executable is the normal binary and will be changed when the Flatpak builds it.

AppImages also aren't provided anymore, is res/AppRun still needed?

@LunaTheFoxgirl
Copy link
Member

It is not, more cleanup needs to happen + I need to get around to make a WIX installer for Windows.

@ExpiredPopsicle ExpiredPopsicle removed the Triage PR/Issue needs to be triaged. label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants