Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Preserving Folder Structure #395

Merged
merged 18 commits into from
Sep 11, 2024
Merged

Feature: Preserving Folder Structure #395

merged 18 commits into from
Sep 11, 2024

Conversation

r888800009
Copy link
Contributor

  • Refactor source/creator/io/package.d confusing code
  • Add the KRA/PSD import "Preserve Folder Structure" configuration option
  • Add DialogHandler
image image

@r888800009
Modify function to conform to review feedback
8b6adfb
@r888800009
Rename "Autosaves" Pane to "File Handling" to make it more versatile.
ce2e3a0
@r888800009
Fixed inconsistent display of "Zoom Mode" configuration
1188835
@r888800009
Refactor problematic code
c8724e6
@r888800009
Allow user configuration to import preserve folder structure
aeb8d87
@r888800009
Update based on review feedback
255d4b7
@r888800009
Refactor incMessageBox() with enum args and return value
d2327a8
@r888800009
refector incImportKeepFolderStructPop() with enum return value
e6e628b
@r888800009
rename incConvertToTinyfdButton() to incDialogButtonToTinyfd()
497eb85
@r888800009
reuse DialogButton enum in dialog.d
ce17ff3
@r888800009
Implement class DialogHandler and remove incMessageBox() to avoid env…
c50feb5 
…ironmental issues
@r888800009
Revert "Modify function to conform to review feedback"
e841c3a 
This reverts commit 8b6adfb.
@r888800009
Revert "Fixed inconsistent display of "Zoom Mode" configuration"
7e8ffab 
This reverts commit 1188835.
@r888800009
Clone kra-d git to fix kra import issue
46cf100 
Note: run `dub upgrade` before build
@r888800009
Duplicate Dialog return value avoids mistakes reuse reference
fcddd84
@r888800009
Merge branch 'v0_8' into v0_8-preserve-layer-structure
96b87bc
@github-actions github-actions bot added the Triage PR/Issue needs to be triaged. label Sep 11, 2024
This was referenced Sep 11, 2024
Merged
Merged
Merged
@LunaTheFoxgirl
Copy link
Member

Right now this depends on a specific commit of kra-d; please make a PR to kra-d first and let me release a new version if you've made any fixes.

@r888800009
Copy link
Contributor Author

Right now this depends on a specific commit of kra-d; please make a PR to kra-d first and let me release a new version if you've made any fixes.

@LunaTheFoxgirl This fix is ​​based on the latest kra-d commit. You may need to run dub upgrade before build.

Inochi2D/kra-d@6a0bd41
Inochi2D/kra-d#1

@LunaTheFoxgirl
Copy link
Member

Right now this depends on a specific commit of kra-d; please make a PR to kra-d first and let me release a new version if you've made any fixes.

@LunaTheFoxgirl This fix is ​​based on the latest kra-d commit. You may need to run dub upgrade before build.

Inochi2D/kra-d@6a0bd41 Inochi2D/kra-d#1

Ah, I missed that, please change the version specification to ~>0.5.6; that includes that change.

@LunaTheFoxgirl LunaTheFoxgirl added Enhancement New feature or request and removed Triage PR/Issue needs to be triaged. labels Sep 11, 2024
@github-actions github-actions bot added the Triage PR/Issue needs to be triaged. label Sep 11, 2024
LunaTheFoxgirl
LunaTheFoxgirl requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@LunaTheFoxgirl LunaTheFoxgirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just one problem left in dub.sdl

dub.sdl Outdated Show resolved Hide resolved
@LunaTheFoxgirl
Copy link
Member

LGTM

@LunaTheFoxgirl LunaTheFoxgirl merged commit ca5c4f0 into Inochi2D:v0_8 Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunaTheFoxgirl LunaTheFoxgirl LunaTheFoxgirl approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request Triage PR/Issue needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r888800009 @LunaTheFoxgirl