Shortcuts handling and font rendering fixes #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows with some keyboard layouts Right Alt (AltGr) acts the same as Ctrl+Alt. In incShortcut check for exact pressed modifiers and be explicit about not supporting shortcuts with Ctrl+Alt. See: https://en.wikipedia.org/wiki/AltGr_key#Ctrl+Alt This fixes bug where shortcuts were triggered while typing special characters with AltGr on these keyboard layouts.
Latin characters seem to render incorrectly using CJK variant of Noto font (cut bottom pixels on text, missing characters like polish diacritics among others). Use NotoSans-Regular for these characters and add more ranges supported by this font, like Greek and Cyrillic.
lubasowo0
changed the title
lubasowo0
changed the title
|
LGTM, letting the CI build test to run to make sure there's no build issues has arisen. If that is in the clear I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This little patchset fixes bugs I encountered during translation of Inochi Creator to polish. It fixes typing polish diacritics into textboxes using keyboard with AltGr key on Windows, which incorrectly triggered some shortcuts (more info in commit message). It also changes font using to render non-CJK characters into NotoSans-Regular because CJK version missed some needed characters. Let me know if this is the correct approach.