Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance undo impl3 #64

Merged
merged 6 commits into from
Aug 11, 2022
Merged

Enhance undo impl3 #64

merged 6 commits into from
Aug 11, 2022

Conversation

seagetch
Copy link
Contributor

Changes:

  • Changed some undo / redo actions not to store all states regarding UI (e.g. MeshEditor, and CatmullSpline) so that garbage collector can collect them appropriately.
  • Changed some undo / redo actions not to store both old and new states to improve memory efficiency.
  • Fix problems of dealing of actionPointer in actionstack.d regarding the end of undo stack.

Known Issue:

  • It seems some PathDeformation undo has some bugs remained in minor condition. I cannot reproduce the situation so far.
    (It might be the result of complex operation of redo and undo.)

@LunaTheFoxgirl LunaTheFoxgirl merged commit 5ba3054 into Inochi2D:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seagetch @LunaTheFoxgirl