Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use ExceptionHandler for OperationsResources controller #766

Merged
merged 5 commits into from
Sep 26, 2024
Merged

feat: use ExceptionHandler for OperationsResources controller #766

merged 5 commits into from
Sep 26, 2024

Conversation

EmmanuelDemey
Copy link
Collaborator

No description provided.

FBibonne
FBibonne requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@FBibonne FBibonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si on utilise l'exception handler, du coup, on peut affiner les types retournés( voir les commentaires)

Il faudrait aussi retirer la javadoc des méthodes dans OperationsResources car elle n'apporte rien

src/main/java/fr/insee/rmes/webservice/operations/OperationsResources.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/webservice/operations/OperationsResources.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/webservice/operations/OperationsResources.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/webservice/operations/OperationsResources.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/webservice/operations/OperationsResources.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/webservice/operations/OperationsResources.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@EmmanuelDemey EmmanuelDemey merged commit fd7e1dc into main Sep 26, 2024
1 check failed
@EmmanuelDemey EmmanuelDemey deleted the fix/error-post-operation branch September 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBibonne FBibonne FBibonne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmmanuelDemey @FBibonne