Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create a method to convert JSONArray to stream #807

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: create a method to convert JSONArray to stream #807

merged 2 commits into from
Nov 19, 2024

Conversation

EmmanuelDemey
Copy link
Collaborator

No description provided.

@EmmanuelDemey EmmanuelDemey linked an issue Nov 18, 2024 that may be closed by this pull request
Remplacer toutes les boucles for sur un objet JSONArray par une Stream #806
Closed
FBibonne
FBibonne reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@FBibonne FBibonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca me va !

Reprendre maintenant toutes les boucles pour les refactorer, y compris fr.insee.rmes.utils.JSONUtils#jsonArrayOfStringToString

src/main/java/fr/insee/rmes/utils/JSONUtils.java Outdated Show resolved Hide resolved
src/main/java/fr/insee/rmes/utils/JSONUtils.java Outdated Show resolved Hide resolved
src/test/java/fr/insee/rmes/utils/JSONUtilsTest.java Outdated Show resolved Hide resolved
src/test/java/fr/insee/rmes/utils/JSONUtilsTest.java Show resolved Hide resolved
FBibonne
FBibonne reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@FBibonne FBibonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca me va.

Maintenant, il s'agit de remplacer toutes les boucles for sur des JSONArray, y compris celle dans fr.insee.rmes.utils.JSONUtils#jsonArrayOfStringToString

@EmmanuelDemey EmmanuelDemey mentioned this pull request Nov 19, 2024
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@FBibonne
Copy link
Member

On crée une nouvelle issue pour revoir les autres parties du code ?

@EmmanuelDemey EmmanuelDemey merged commit a6334da into main Nov 19, 2024
1 of 2 checks passed
@EmmanuelDemey EmmanuelDemey deleted the 806-remplacer-toutes-les-boucles-for-sur-un-objet-jsonarray-par-une-stream branch November 19, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBibonne FBibonne FBibonne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remplacer toutes les boucles for sur un objet JSONArray par une Stream
2 participants
@EmmanuelDemey @FBibonne