Ensure useFromNow does not trigger any re-render (impl dom level update) #905
+100
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
We don't have to merge it if you don't want to but it's intresting enough |
ddecrulle
reviewed
Dec 20, 2024
Comment on lines
+16
to
+48
| export function useFromNow(params: { dateTime: number | undefined }) { | ||
| const { dateTime } = params; | ||
|
|
||
| const id = useId(); | ||
|
|
||
| const fromNowText = useMemo(() => <span id={id}></span>, [id]); | ||
|
|
||
| const updateNode = useConstCallback(() => { | ||
| if (dateTime === undefined) { | ||
| return; | ||
| } | ||
|
|
||
| const el = document.getElementById(id); | ||
|
|
||
| if (el === null) { | ||
| return; | ||
| } | ||
|
|
||
| el.innerHTML = fromNow({ dateTime }); | ||
| }); | ||
|
|
||
| useEffect(() => { | ||
| updateNode(); | ||
| }, [dateTime, id]); | ||
|
|
||
| useEffect(() => { | ||
| const timer = setInterval(updateNode, 1000); | ||
|
|
||
| return () => clearInterval(timer); | ||
| }, []); | ||
|
|
||
| return { fromNowText }; | ||
| } |
There was a problem hiding this comment.
This is an interesting implementation. In my opinion, it's much more convenient that the hook returned a string instead of a ReactNode. Additionally, there is a type issue: fromNowText is currently typed as any. While this implementation is more complex than the previous one and has some benefits, I don’t believe they are sufficient to justify merging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.