Upload percentage now checks if the file size is 0 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odysseu
commented
Jan 23, 2025
| @@ -80,7 +80,7 @@ export const { reducer, actions } = createUsecaseActions({ | |||
| directoryPath, | |||
| basename, | |||
| size, | |||
| uploadPercent: 0 | |||
| uploadPercent: size === 0 ? 100 : 0 | |||
There was a problem hiding this comment.
Not sure here because maybe at first we want the file uploadPercent to be at 0, and only then the uploadProgress method updates the content
There was a problem hiding this comment.
The action is dispatch before we start the request to s3. Even through we know the file size, the uploadPercent should be at 0.
|
|
Thank you, @odysseu. I've just pushed a correction to completely fix the issue caused by division by zero and restore the state as mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #529 for good