Realize Reproducible Builds by stabilize name of the KoinMeta file
#196
+31
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kengo TODA <toda_k@henry.jp>
Signed-off-by: Kengo TODA <toda_k@henry.jp>
Signed-off-by: Kengo TODA <toda_k@henry.jp>
|
note that this change includes the fix suggested by #195 |
| val allDefinitions = (moduleList + default).flatMap { it.definitions } | ||
| val tempFile = createTempFile("KoinMeta", ".kt") | ||
| val sha256 = MessageDigest.getInstance("SHA-256"); | ||
| DigestOutputStream(tempFile.outputStream(), sha256).buffered().use { |
There was a problem hiding this comment.
ok, let's go with that 👍
|
merged in c5afa3a |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation decides the name of
KoinMetafile randomly, and it makes the build not reproducible. In other words,kspKotlintask generates different output even when input is same.By this behaviour, Gradle tasks depending on the generated
KoinMetafile likecompileKotlinare executed even though no code has been changed. I will share screenshot of Gradle build scan for reference:I want to suggest this change to stabilize name of the
KoinMetafile. By this change, koin-ksp-compiler will compute digest of generated file, then use it to name theKoinMetafile. It will make thekspKotlintask reproducible, and make successor tasks able to use build cache.