Image viewer for package demos #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
force-pushed
the
demo-image-view
branch
15 times, most recently
from
d9f0331 to
692d6d8
Compare
PaulHax
force-pushed
the
demo-image-view
branch
from
9cf5f78 to
5829523
Compare
PaulHax
force-pushed
the
demo-image-view
branch
2 times, most recently
from
ec0eccb to
0743f0a
Compare
thewtex
reviewed
Apr 3, 2024
| "@itk-viewer/element": "^0.2.12", | ||
| "@itk-viewer/io": "^0.1.8", | ||
| "@shoelace-style/shoelace": "^2.12.0", | ||
| "itk-wasm": "1.0.0-b.170", |
|
This is worth a review. The |
thewtex
approved these changes
Apr 5, 2024
| @@ -89,7 +61,8 @@ <h3>👨💻 Live API Demo ✨</h3> | |||
| <sl-details disabled id="compareImages-metrics-details" summary="metrics: Metrics for the baseline with the fewest number of pixels outside the tolerances."></sl-details> | |||
| <sl-button variant="neutral" outline name="metrics-download" disabled>Download</sl-button> | |||
| <br /><br /> | |||
| <sl-details disabled id="compareImages-difference-image-details" summary="differenceImage: Absolute difference image"></sl-details> | |||
| <!-- <sl-details disabled id="compareImages-difference-image-details" summary="differenceImage: Absolute difference image"></sl-details> --> | |||
| @@ -115,7 +88,8 @@ <h3>👨💻 Live API Demo ✨</h3> | |||
| </sl-select> | |||
| <sl-button variant="neutral" outline name="difference-image-download" disabled>Download</sl-button> | |||
| <br /><br /> | |||
| <sl-details disabled id="compareImages-difference-uchar-2d-image-details" summary="differenceUchar2dImage: Unsigned char, 2D difference image for rendering"></sl-details> | |||
| <!-- <sl-details disabled id="compareImages-difference-uchar-2d-image-details" summary="differenceUchar2dImage: Unsigned char, 2D difference image for rendering"></sl-details> --> | |||
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "name": "@itk-wasm/demo-app", | |||
| "version": "0.0.0", | |||
| "name": "@itk-wasm/demo-app", | ||
| "version": "0.0.0", | ||
| "packageManager": "pnpm@8.11.0", | ||
| "description": "Try pipelines in a browser", |
There was a problem hiding this comment.
Try itk-wasm pipelines in a browser
There was a problem hiding this comment.
Addressed all the comments!
PaulHax
force-pushed
the
demo-image-view
branch
from
79458b7 to
8f4e620
Compare
|
Please rebase for CI testing. |
Manually updated readImage and compareImages TS code and index.html.
PaulHax
force-pushed
the
demo-image-view
branch
from
ef742c3 to
2ac281c
Compare
Reflect disable attribute in itk-image-details so cypress waits until enabled to click. Ask cypress to query the shadow dom.
PaulHax
force-pushed
the
demo-image-view
branch
from
2ac281c to
67596fd
Compare
|
All checks green 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itk-image-detailscomponentdemo-apppackage?Dev steps to rebuild demo web app
Make edits in
packages/core/typescript/itk-wasm/src/bindgen/typescript/demoThen in a package, ie
packages/downsampleThen in typescript dir, ie
packages/downsample/typescript