fix(WebAssemblyInterface): support vector/multi-component images #1166
Conversation
| @@ -84,7 +84,7 @@ class ITK_TEMPLATE_EXPORT OutputImage | |||
|
|
|||
| const auto dataAddress = reinterpret_cast< size_t >( wasmImage->GetImage()->GetBufferPointer() ); | |||
| using ConvertPixelTraits = DefaultConvertPixelTraits<typename ImageType::PixelType>; | |||
| const auto dataSize = wasmImage->GetImage()->GetPixelContainer()->Size() * sizeof(typename ConvertPixelTraits::ComponentType) * ConvertPixelTraits::GetNumberOfComponents(); | |||
| const auto dataSize = wasmImage->GetImage()->GetPixelContainer()->Size() * sizeof(typename ConvertPixelTraits::ComponentType); | |||
There was a problem hiding this comment.
GetPixelContainer()->Size() already includes number of components.
|
@thewtex I'm guessing we don't have any multi-component image already in |
@jadh4v thanks for the patch! Yes, could you please add a test, similar to: that uses test/Input/apple.jpg as an input and, |
jadh4v
force-pushed
the
fix-WebAssemblyInterface-vector-images
branch
from
7d7fb2b to
68f2174
Compare
|
My test still fails on image comparison. I think this maybe because of jpeg format?? Trying itk::WriteImage(convertedImage, outputImageFile)
<DartMeasurement name="ImageError apple.jpg" type="numeric/double">1934</DartMeasurement>
<DartMeasurement name="ImageError" type="numeric/double">1934</DartMeasurement>
<DartMeasurement name="ImageError Minimum" type="numeric/double">3</DartMeasurement>
<DartMeasurement name="ImageError Maximum" type="numeric/double">8</DartMeasurement>
<DartMeasurement name="ImageError Mean" type="numeric/double">3.42037</DartMeasurement>
<DartMeasurementFile name="DifferenceImage" type="image/png">/home/jadhav/code/native-itkwasm/ITK-Wasm-build/Testing/Temporary/WebAssemblyInterface/itkWasmVectorImageInterfaceTest.jpg.diff.png</DartMeasurementFile>
<DartMeasurementFile name="BaselineImage" type="image/png">/home/jadhav/code/native-itkwasm/ITK-Wasm-build/Testing/Temporary/WebAssemblyInterface/itkWasmVectorImageInterfaceTest.jpg.base.png</DartMeasurementFile>
<DartMeasurementFile name="TestImage" type="image/png">/home/jadhav/code/native-itkwasm/ITK-Wasm-build/Testing/Temporary/WebAssemblyInterface/itkWasmVectorImageInterfaceTest.jpg.test.png</DartMeasurementFile>
<DartMeasurement name="BaselineImageName" type="text/string">apple.jpg</DartMeasurement> |
|
@jadh4v thanks!
Yes, we can use .mha -- I will create a patch, add it to the branch. I will build / push the docker images and update the branch accordingly. |
thewtex
force-pushed
the
fix-WebAssemblyInterface-vector-images
branch
from
68f2174 to
b89bcb6
Compare
Fix buffer size calculations and number of components for handling vector images.