BUG: Set 'GetDataObject' function signature to const

When throwing exceptions, getting the data object pointer should be always be constant.
InsightSoftwareConsortium · Dec 14, 2019 · 42bfdd5 · 42bfdd5
1 parent c7fd5bd
commit 42bfdd5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Modules/Core/Common/include/itkDataObject.h b/Modules/Core/Common/include/itkDataObject.h
@@ -77,12 +77,14 @@ class ITKCommon_EXPORT DataObjectError : public ExceptionObject
   void
   SetDataObject(DataObject * dobj) noexcept;
 
-  /** Get the data object that is throwing this exception. */
-  DataObject *
-  GetDataObject() noexcept;
 
+  /** Get the data object that is throwing this exception. */
   const DataObject *
   GetDataObject() const noexcept;
+#if !defined(ITK_LEGACY_REMOVE)
+  DataObject *
+  GetDataObject() noexcept;
+#endif
 
 protected:
   /** Print exception information.  This method can be overridden by

diff --git a/Modules/Core/Common/src/itkDataObject.cxx b/Modules/Core/Common/src/itkDataObject.cxx
@@ -64,11 +64,13 @@ DataObjectError ::SetDataObject(DataObject * dobj) noexcept
   m_DataObject = dobj;
 }
 
+#if !defined(ITK_LEGACY_REMOVE)
 DataObject *
 DataObjectError ::GetDataObject() noexcept
 {
   return m_DataObject;
 }
+#endif
 
 const DataObject *
 DataObjectError ::GetDataObject() const noexcept