BUG: Add missing const 'GetDataObject' function signature

InsightSoftwareConsortium · Dec 14, 2019 · c7fd5bd · c7fd5bd
1 parent 5b4eaa2
commit c7fd5bd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/Modules/Core/Common/include/itkDataObject.h b/Modules/Core/Common/include/itkDataObject.h
@@ -81,6 +81,9 @@ class ITKCommon_EXPORT DataObjectError : public ExceptionObject
   DataObject *
   GetDataObject() noexcept;
 
+  const DataObject *
+  GetDataObject() const noexcept;
+
 protected:
   /** Print exception information.  This method can be overridden by
    * specific exception subtypes.  The default is to print out the

diff --git a/Modules/Core/Common/src/itkDataObject.cxx b/Modules/Core/Common/src/itkDataObject.cxx
@@ -70,6 +70,13 @@ DataObjectError ::GetDataObject() noexcept
   return m_DataObject;
 }
 
+const DataObject *
+DataObjectError ::GetDataObject() const noexcept
+{
+  return m_DataObject;
+}
+
+
 void
 DataObjectError ::PrintSelf(std::ostream & os, Indent indent) const
 {

diff --git a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterTest.cxx
@@ -150,7 +150,7 @@ itkJoinSeriesImageFilterTest(int, char *[])
   catch (const itk::ExceptionObject & err)
   {
     std::cout << err << std::endl;
-    auto * errp = dynamic_cast<itk::DataObjectError *>(&err);
+    const auto * const errp = dynamic_cast<const itk::DataObjectError * const>(&err);
     if (errp)
     {
       errp->GetDataObject()->Print(std::cout);