-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improve itkEuclideanDistancePointMetric coverage. #113
ENH: Improve itkEuclideanDistancePointMetric coverage. #113
Conversation
@jhlegarreta This has been stale for 2 years now waiting to make it perfect. It seems like the current additions are worthy of inclusion, and the additional work can be a separate PR. |
Jon Hait... Gorroño Kitware Build Robot Davis Vigneault Jon Hait... Gorroño Hans J. Johnson |
Accidently deleted/closed branch when the script for moving from Gerrit went haywire. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not ready to be merged: it should be rebased on master (e.g. typedef
s around), and as said in the follow-up it required more work. So let's leave it unmerged, and I'll have a look as time permits.
Since I started it in gerrit, unless you find the time to do it, leave it on me.
Exercise basic object methods. Exercise all Set/Get macros. Refactor the test to accept input parameters to test all possible conditions.
3ddf00a
to
49bc2e3
Compare
@hjmjohnson I've seen that you worked on this. Thanks. I just did a few more changes (used Let's merge it for keeping things moving forward, and some time in the future, when I am in a position to come back to the code coverage issues, I'll check the necessary additions to do. Thanks for your patience. |
@jhlegarreta Merging based on your comment. |
Thanks @hjmjohnson. Moving forward ! |
Not seeing the CIs right now or where they were failing/how InsightSoftwareConsortium/ITKExamples/#149 would fix them, but thanks @thewtex . I guess clang formatting will need to be applied as well. |
It looks like this PR was merged a year ago. InsightSoftwareConsortium/ITKSphinxExamples#149 adds an example, and does not attempt to fix anything. If you wanted to make follow-up improvements to this, a new PR is in order. Or am I misunderstanding something? |
Sorry @dzenanz. My bad. Since it was being cross-ref'ed and given that I did not pay due attention to the status ( |
Exercise basic object methods.
Exercise all Set/Get macros.
Refactor the test to accept input parameters to test all possible
conditions.