WIP: 3393 transform image io as shared #115
Conversation
…SoftwareConsortium#3393 This commit updates the Mesh IO factory to ensure it can be built as shared library so it is registered only once when linked to both a main application and application plugin dynamically loaded. In a nutshell, it updates the code so the itk::MeshIOFactory is registered only once when statically initialized. More specifically, it applies the following changes: (1) Uses of "RegisterFactoryInternal" to make sure the factory is registered once into the TransformIOFactory. See 39b4ab3 (BUG: Internal factory must use RegisterFactoryInternal method) for more details. (2) Introduces ITKIOMesh explicit instantiation where templated reader and writer are explicitly instantiated over dimensions, types and traits. This will allow templated factories to be registered in one translation unit and instantiated in an other. See http://stackoverflow.com/questions/8024010/why-do-template-class-functions-have-to-be-declared-in-the-same-translation-unit (3) Update TestDriver to explicitly register the MeshIO factories needed by QuadEdgeMeshFiltering and ITKIOMesh tests. Note that in a follow-up commit, the MeshIO library will be split into multiple modules MeshIOBase and one for (or one for each) Mesh IO factories. Open questions: (1) It is not clear why on Visual Studio 2008, the export macro need to be removed from MeshFileReader. Otherwise, it reports the following link error when building ITKIOMeshTestDriver: error C2487: 'itk::ProcessObject::SetOutput' : member of dll interface class may not be declared with dll interface C:\ath/to\ITKv4\Modules\IO\Mesh\include\itkMeshFileReader.h 77 (2) This commits introduces ITKVoronoi dependency to the ITKIOMesh module. Moving forward, this could be updated by having every module explicitly listing instantiations they expect. Change-Id: I80ea34becae742a63b5c98220b20003303188d9c
…sortium#3393 This change updates Mesh IO infrastructure to be consistent with the Image and Transform ones. Each Mesh factories along with the UseITK file have been updated to ensure static initialization works. "Private" function has been removed from MeshIOFactory and added to each Mesh format specific factories. Change-Id: I213e51b2a41677d3430e08cf1d81b41b3221c6ec
This commit updates explicit instantiation to use "extern" keyword similarly to what was done in InsightSoftwareConsortium/ITK@b72726c (BUG: Explicitly instantiate common MetaDataObjects). While "extern" is only part of the c++ standard starting with c++11 (see section 14.7.2 of the standard), it is supported by Visual Studio 2008, GCC and Clang using compiler specific extension in earlier version: * Visual Studio 2008: https://msdn.microsoft.com/en-us/library/by56e477(v=vs.90).aspx * Gcc: https://gcc.gnu.org/onlinedocs/gcc-4.8.4/gcc/Template-Instantiation.html#Template-Instantiation * Clang (since v2.9): http://clang.llvm.org/cxx_status.html For completeness, initial draft of the "extern" keyword were first introduced in 2003 [1] and then revised in 2006 [2], and ultimately standardized in c++11 [3]: [1] N1448: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2003/n1448.pdf [2] N1987: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2006/n1987.htm [3] N3242: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/ See InsightSoftwareConsortium#3393 Change-Id: I74a9260e4ad9996470a54159c55cae6a7fa7f10d
…InsightSoftwareConsortium#3393 Change-Id: Idea55bf05e92d3266e27f711d2f29256b9f0d44b
|
http://review.source.kitware.com/#/c/20548/ Jean-Chr...on-Robin Kitware Build Robot Jean-Chr...on-Robin Kitware Build Robot Jean-Chr...on-Robin Kitware Build Robot Hans J. Johnson Johan Andruejol Kitware Build Robot Matt McCormick Hans J. Johnson Jean-Chr...on-Robin Francois Budin Jean-Chr...on-Robin |
|
@jcfr @fbudin69500 Is there value in this long outstanding PR from gerrit? It has been stale for almost a year. |
|
Accidently deleted/closed branch when the script for moving from Gerrit went haywire. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status:Use_Milestone_Backlog
stale
bot
removed
the
status:Use_Milestone_Backlog
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status:Use_Milestone_Backlog
|
I think that a lot of this got integrated in other patches over the years. @jcfr Can you check whether this can be closed, or something still needs to be done? |
stale
bot
removed
the
status:Use_Milestone_Backlog
|
This is now so far outdated that the current PR is probably no longer relevant as a starting point. |
|
For reference, these commits were integrated as 1869a17 |
No description provided.