ENH: Added jacobian computation to ComposeScaleSkewVersorTransform #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computed Jacobian using SymPy. See comments in code for computation script. Added test to verify Jacobian with finite difference results.
dzenanz
reviewed
Apr 7, 2020
Modules/Core/Transform/include/itkComposeScaleSkewVersor3DTransform.hxx
Outdated
Show resolved
Hide resolved
|
Very nice! I recall doing something similar and thinking is was "too" complicated, but this looks simpler. It will be interesting to see how it compare for registration with the additive composite transform. |
COMP: Removed unused variables. Resolved shadowed variable.
dzenanz
approved these changes
Apr 7, 2020
|
Preferably squash upon merge. |
|
😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computed Jacobian using SymPy. See comments in code for computation
script.
Added test to verify Jacobian with finite difference results.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.