WIN32 is not necessarily defined _WIN32 should be #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo or intentional? _WIN32 is described in https://msdn.microsoft.com/en-us/library/b0084kay(v=vs.140).aspx for all editions WIN32 is not defined for any. Thus the reason to not change this would be to somehow take into account windows c++ compilers that does not define this flag by default. However, on my combination of cmake flags WIN32 were not defined at compile-time. (On Windows 8.1 with Visual studio v140, v120 and the Intel C++ Compiler 17.0 - Using ExternalProject_Add almost the same way Slicer do, but without the VTK dependency)
|
I realized WIN32 not being defined was due to my CMake flags not being parsed properly. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo or intentional?
_WIN32 is described in https://msdn.microsoft.com/en-us/library/b0084kay(v=vs.140).aspx for all editions WIN32 is not defined for any. Thus the reason to not change this, would be to somehow take into account windows c++ compilers that does not define this flag by default. However, on my combination of cmake flags WIN32 were not defined at compile-time.
(On Windows 8.1 with Visual studio v140, v120 and the Intel C++ Compiler 17.0 - Using ExternalProject_Add almost the same way Slicer do, but without the VTK dependency)