BUG: Similarity3DTransform::SetScale should recompute m_Offset #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
dzenanz
approved these changes
Jul 5, 2021
|
I guess you got the formula wrong. |
Addressed issue InsightSoftwareConsortium#2629 "Similarity3DTransform::SetScale should recompute m_Offset", which said: > When `Similarity3DTransform::SetScale` is called, it does not compute > `m_Offset`, which appears to cause an incorrect result from > `similarity3DTransform.TransformPoint` when `TransformPoint` is called > directly after `SetScale`. Included a unit test (GoogleTest) to ensure that the issue is fixed.
N-Dekker
force-pushed
the
SimilarityTransform.SetCenterAndScale
branch
from
7944f73 to
0dcd550
Compare
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jul 8, 2021
Following ITK issue InsightSoftwareConsortium/ITK#2629 and pull request InsightSoftwareConsortium/ITK#2627
N-Dekker
changed the title
dzenanz
approved these changes
Jul 8, 2021
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jul 12, 2021
Following ITK issue InsightSoftwareConsortium/ITK#2629 and pull request InsightSoftwareConsortium/ITK#2627
|
Added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2629 "Similarity3DTransform::SetScale should recompute m_Offset", which said:
Included a unit test (GoogleTest) to ensure that the issue is fixed.