-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: switch to zlib-ng official repository #2803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
added a commit
to dzenanz/zlib-ng
that referenced
this pull request
Oct 11, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803 CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025 commit 5434d42 adds bad whitespace: README.md:223: new blank line at EOF. commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Dead2
pushed a commit
to zlib-ng/zlib-ng
that referenced
this pull request
Oct 13, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803 CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025 commit 5434d42 adds bad whitespace: README.md:223: new blank line at EOF. commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
A bunch of PRs just merged upstream. Might want to resync one more time before merge. |
Code extracted from: https://github.com/zlib-ng/zlib-ng.git at commit a7b773697b34c19f246defc1ffb760b0d39be391 (develop).
# By Zlib-ng Upstream * upstream-zlib-ng: zlib-ng 2021-10-13 (a7b77369)
I just saw that too. I am mostly on vacation this week and the next, so I will respond slowly 😄 |
thewtex
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🥡
nmoinvaz
pushed a commit
to nmoinvaz/zlib-ng
that referenced
this pull request
Oct 22, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803 CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025 commit 5434d42 adds bad whitespace: README.md:223: new blank line at EOF. commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
nmoinvaz
pushed a commit
to nmoinvaz/zlib-ng
that referenced
this pull request
Oct 22, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803 CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025 commit 5434d42 adds bad whitespace: README.md:223: new blank line at EOF. commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Dead2
pushed a commit
to zlib-ng/zlib-ng
that referenced
this pull request
Dec 13, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803 CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025 commit 5434d42 adds bad whitespace: README.md:223: new blank line at EOF. commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Dead2
pushed a commit
to zlib-ng/zlib-ng
that referenced
this pull request
Dec 24, 2021
From ITK PR: InsightSoftwareConsortium/ITK#2803 CI check: https://github.com/InsightSoftwareConsortium/ITK/runs/3864083025 commit 5434d42 adds bad whitespace: README.md:223: new blank line at EOF. commit 5434d42 is not allowed; missing newline at the end of file in .gitattributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:ThirdParty
Issues affecting the ThirdParty module
type:Enhancement
Improvement of existing methods or implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that biggest PR to zlib-ng was merged, we can switch to the official repository.
Edit: all my PRs were merged, now we can directly use upstream.