Improve thread-safety, reduce code duplication internal I/O factory registration #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
Eases registering an internal factory exactly once, taking thread-safety into account by means of C++11 "magic statics".
Replaced the use of file-scope static `HasBeenRegistered` variables for
conditional `RegisterOneFactory()` calls by the equivalent thread-safe
`ObjectFactoryBase::RegisterInternalFactoryOnce<TFactory>()` calls.
Using Notepad++ v8.1.4, Find in Files (Regular expression):
Find what: if \(!.+IOFactoryHasBeenRegistered\)\r\n {\r\n .+IOFactoryHasBeenRegistered = true;\r\n (.+)::RegisterOneFactory\(\);\r\n }
Replace with: ObjectFactoryBase::RegisterInternalFactoryOnce<$1>\(\);
N-Dekker
force-pushed
the
RegisterFactoryOnce
branch
from
4bf5b7c
to
fb47ffa
Compare
Leengit
reviewed
Oct 15, 2021
Leengit
reviewed
Oct 15, 2021
thewtex
approved these changes
Oct 20, 2021
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved thread-safety by replacing the use of file-scope static
HasBeenRegisteredvariables with C++11 "magic statics", to implement internal I/O factory registration.Reduced code duplication by adding a helper member function template,
ObjectFactoryBase::RegisterInternalFactoryOnce<TFactory>().