BUG: fix uninitialized memory warning in PeriodicBoundaryCondition test #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image buffer needs to be filled with values before usage. Also, convert a print statement to a check for an expected value.
7 tasks
github-actions
bot
added
area:Core
dzenanz
approved these changes
Oct 27, 2021
seanm
approved these changes
Oct 27, 2021
|
thx @blowekamp this is much better. |
thewtex
approved these changes
Oct 27, 2021
N-Dekker
reviewed
Oct 27, 2021
N-Dekker
reviewed
Oct 27, 2021
| @@ -312,7 +314,7 @@ itkPeriodicBoundaryConditionTest(int, char *[]) | |||
| } | |||
| ++testIter; | |||
| } | |||
| std::cout << "Dummy sum: " << sum << std::endl; | |||
| ITK_TEST_EXPECT_EQUAL(sum, testSize[0] * testSize[1] * 3); | |||
There was a problem hiding this comment.
Where does the number 3 come from? Maybe you could use back.size() instead...?
There was a problem hiding this comment.
Yup, that would be further improvement. I miss some of the details with that new fangled for new, when I made the change. I think this is better than a plain 12288 number it should be OK.
N-Dekker
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
@blowekamp Approved, of course, but please consider my comment to avoid the "magic number" 3: #2841 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image buffer needs to be filled with values before usage. Also,
convert a print statement to a check for an expected value.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.