Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Removing relative header imports from multiple cxx files #2895

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

PranjalSahu
Copy link
Contributor

Removing relative imports from files in Modules including Filtering, Core, IO, Numerics, Registration, Segmentation.
Four more files remaining under ThirdParty/KWIML/src/itkkwiml/test.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Nov 22, 2021
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not modify stuff inside Modules/ThirdParty/. Also, stuff inside that directory should not have tests. Most update scripts exclude tests.

@dzenanz dzenanz requested a review from hjmjohnson November 22, 2021 22:34
@PranjalSahu
Copy link
Contributor Author

We should not modify stuff inside Modules/ThirdParty/. Also, stuff inside that directory should not have tests. Most update scripts exclude tests.

Yes, that's why I didn't include those.

@dzenanz dzenanz merged commit ebc115e into InsightSoftwareConsortium:master Nov 23, 2021
@PranjalSahu PranjalSahu deleted the pranjal5 branch February 1, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants